[dataprotection] Correct command example for dpp blobs#8621
[dataprotection] Correct command example for dpp blobs#8621IannGeorges wants to merge 1 commit intoAzure:mainfrom
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| dataprotection restorable-time-range find | cmd dataprotection restorable-time-range find update parameter source_data_store_type: updated property choices from ['ArchiveStore', 'OperationalStore', 'VaultStore'] to ['ArchiveStore', 'OperationalStore'] |
|
Hi @IannGeorges, |
|
Hi @IannGeorges, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
microsoft-github-policy-service
Bot
requested review from
calvinhzy,
evelyn-ys and
yonzhan
|
Hi @IannGeorges Release SuggestionsModule: dataprotection
Notes
|
@evelyn-ys Is a log update for the module required for editing a command's documentation? (One parameter was removed) |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@IannGeorges This PR is actually a breaking change. It's not just a doc update, it will break existing script if the script use Of course you need to mention the change in history notes. If you want to release a new version to make the change live, you need to update the version as well. But I'm afraid you can't release breaking change directly. cc @ReaNAiveD for extension breaking change guidance |
|
Hi @IannGeorges , The Azure CLI team is implementing a new policy requiring a 30-day pre-announcement for all breaking changes. Please create a pull request to add a breaking change announcement according to the guidelines in the documentation. The breaking change can be released 30 days after the announcement is published. https://github.com/Azure/azure-cli/blob/dev/doc/how_to_introduce_breaking_changes.md |
4 participants
This PR is removing an incorrect parameter from the command documentation. VaultStore does not support restorable-time-range for recovery point since they are discrete RPs & not continuous.
Docs: https://learn.microsoft.com/en-us/cli/azure/dataprotection/restorable-time-range?view=azure-cli-latesthttps://learn.microsoft.com/en-us/cli/azure/dataprotection/restorable-time-range?view=azure-cli-latest
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.